[OpenSER-Devel] Bug in rule.c of Openser permissions module

[Bogdan-Andrei Iancu]

Hi Giovanni,

That is totally correct - thanks a lot for the fix. It was applied on 
CVS on devel, 1.2.x and 1.1.x versions.

Regards,
Bogdan

Giovanni Coriasco wrote:
> Hi,
> I think I found a bug in the code of the permissions module.
>
> The problem was that only the first line of the allow_routing 
> permission files were handled properly. I found the problem in the 
> search_rule() function in rule.c.
> The left expression was not properly evaluated because it was read 
> from the 'r' pointer and not from the 'r1' that was the iterated one: 
> thus I changed the expression "(!r->left)" into "(!r1->left)" (at line 
> 105 of "rule.c") and everything seems to work correctly now.
>
> I'm attaching a diff file for the "rule.c" patch to this email.
>
> Bye
>
> Giovanni
>
>
> ------------------------------------------------------------------------