[Devel] [ openser-Feature Requests-1630758 ] domain-module: filter database rows

[SourceForge.net]

Feature Requests item #1630758, was opened at 2007-01-08 17:30
Message generated for change (Comment added) made by klaus_darilion
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743023&aid=1630758&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: None
Status: Closed
Resolution: Invalid
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: domain-module: filter database rows

Initial Comment:
hi
it would be very nice, if the domain-module would be able to filter the database-rows using a where-statement. therefore openser is only responsible for  those domains, which remain after this filtering process.
For example, there is an additional exported module-parameter, which specifies the SQL-where statement that will be used, if set.
Thanks.

----------------------------------------------------------------------

>Comment By: Klaus Darilion (klaus_darilion)
Date: 2007-01-11 09:22

Message:
Logged In: YES 
user_id=1318360
Originator: NO

The domain module is for the domains that openser is responsible. It is
not the task of the domain module to handle your proprietary extensions to
the domain table. Probalby next week someone claims I want another SQL
query to added to the domain module, or "my domain table has a xyz column -
why is the xyz column not used by the domain module?").

It is very clear: The domain module needs a table with returns the domains
for which openser is authoritative.

If you have proprietary extensions, then either
- use the flexible avpoops module
- extend your provisioning process (to only put the needed domains into
the domain table)
- or make a "view" from the openser domain table to your proprietary
domain table. Here you can use any SELECT query to filter from your
proprietary domain table.

----------------------------------------------------------------------

Comment By: Bogdan (bogdan_iancu)
Date: 2007-01-10 16:31

Message:
Logged In: YES 
user_id=1275325
Originator: NO

I guess Klaus is right - if you do not want to have them used, do not put
the domains into DB.

regards,
bogdan

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2007-01-09 18:28

Message:
Logged In: NO 

hi
currently i'm actually using avp_db_query instead of the domain module -
but isn't this much slower than the domain module?
the domain table contains entries not only for using with sip/openser -
other services (like the mta) are using the same table. openser should only
be responsible for domains, where column `service_sip`='local' (other
values could be 'disabled' or '3rdparty'). there is a central table for
domains and only certain rows are assigned to openser.
if it isn't worth upgrading the domain module, avpops is OK too. but in
this case one can consider, that many features of other modules can be
realized with avpops - why should one decide to use these modules, if they
are not faster than the much more flexible avpops module?

----------------------------------------------------------------------

Comment By: Klaus Darilion (klaus_darilion)
Date: 2007-01-09 10:25

Message:
Logged In: YES 
user_id=1318360
Originator: NO

Hi!

I do not think this feature is needed. Just filter the domains before you
put it into the domain table. You can also use AVPOPS raw queries to to
lookup certain parameters related to the domain.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743023&aid=1630758&group_id=139143